From 248417dbab0e84b4e254f5c2242bd57be208d891 Mon Sep 17 00:00:00 2001 From: Carlos Escalante Date: Fri, 12 Jun 2026 18:07:31 -0600 Subject: [PATCH] =?UTF-8?q?PROGRESS:=20deferred=20items=20and=20wishlist?= =?UTF-8?q?=20complete=20=E2=80=94=20nothing=20remains?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Fable 5 --- codebase-review/PROGRESS.md | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/codebase-review/PROGRESS.md b/codebase-review/PROGRESS.md index 75b4f0f..0141461 100644 --- a/codebase-review/PROGRESS.md +++ b/codebase-review/PROGRESS.md @@ -160,13 +160,22 @@ fallback already guarded `len >= 2`). | UX-13 cycle filter | **mostly false positive** — daily-spending already accepts cycle params; the trend is multi-cycle by design | | UX-24 meter labels, UX-22 breadcrumb, shared period navigator (UX-03) | not done — needs dedicated UI; lowest-value remainder | -**The improvement plan is complete** except: 3.4 OpenAPI codegen (deferred until a -response_model sweep), the three smallest 4.7 cosmetic items above, and the -unscheduled 4.9 wishlist (what-if planner, PWA, rate history, contribution -calculator). Tests: **82**. Final false-positive tally across the whole plan: -BE-06, BE-09, BE-10, ARCH-03, ARCH-08, BE-22 (accepted), FE-04, UX-04, UX-11, -UX-13 — the characterization-tests-first approach caught all of them before any -"fix" landed. +**The improvement plan is complete** — and as of 2026-06-12, so is everything +that had been deferred: + +### Final batch (2026-06-12) + +| Item | Status | +|---|---| +| 3.4 OpenAPI codegen: response_model sweep + generated api-types.gen.ts + CI drift gate (caught 2 real drifts: missing SAVINGS enum value, untyped raw_charges) | ✅ | +| UX-03 shared PeriodNavigator · UX-22 breadcrumb · UX-24 meter labels | ✅ | +| Wishlist: rate-history chart (Analytics), contribution calculator (Pensiones), what-if Planificador page, PWA installability | ✅ | +| Bonus fix: sw.js was a self-unregistering stub — `serviceWorker.ready` never resolved, so web push had been silently dead; replaced with a working worker | ✅ | + +Tests: **82**. Final false-positive tally across the whole plan: BE-06, BE-09, +BE-10, ARCH-03, ARCH-08, BE-22 (accepted), FE-04, UX-04, UX-11, UX-13 — the +characterization-tests-first approach caught all of them before any "fix" +landed. **Nothing from the review or wishlist remains.** ### Iteration 1 (2026-06-10)