admin/WealthySmart
1
0
Fork 0
mirror of https://github.com/escalante29/WealthySmart.git synced 2026-07-17 10:48:46 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
Files
881d879ed17836fbca849ff8c680036832beba6a
WealthySmart/codebase-review/PROGRESS.md
Carlos Escalante 881d879ed1
All checks were successful
Deploy to VPS / test (push) Successful in 1m51s
Details
Deploy to VPS / deploy (push) Successful in 1m4s
Details
Gate deploys on backend tests and frontend typecheck; record Phase 1 
The new test job runs the 55-test pytest suite and pnpm typecheck
before the deploy job (needs: test) — a red suite now blocks prod.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-09 20:59:34 -06:00

5.3 KiB
Raw Blame History

Implementation Progress

Tracking execution of 07-improvement-plan.md. Newest entries first within each phase.

Phase 0 — Security Hardening Sprint ✅ DONE

Completed and deployed to production 2026-06-09 (deploy task 81, verified live).

Plan item Status Commit
0.1 Fail-fast configuration (SEC-01, BE-15) ✅ 15ea1ef
0.2 Login hardening: compare_digest + 5/min/IP rate limit (SEC-02, SEC-03) ✅ b412370
0.3 CORS pinned to prod domain + localhost dev (SEC-04) ✅ b412370
0.4 7-day tokens (was 30) + COOKIE_SECURE setting (SEC-05, SEC-08) ✅ 15ea1ef, b412370
0.5 Security headers via Hono middleware (SEC-07, FE-08) ✅ bebd7b5
0.6 Paste-import 1 MB cap / proxy 502 / 401 loop guard (ARCH-05, FE-23, FE-22) ✅ 3a357e4, bebd7b5, ad29cce
0.7 Housekeeping: dead AgentHomeClient removed, dev compose creds → .env, .env.example ✅ 4a758b2, 15ea1ef

Production verification (2026-06-09):

  • Health 200 after deploy; frontend+backend containers recreated, healthy
  • X-Frame-Options: DENY, X-Content-Type-Options: nosniff, Referrer-Policy live on prod responses
  • Login rate limit live: 6th rapid attempt → 429 with Retry-After: 58
  • CORS live: evil.example origin gets no allow header; app origin allowed
  • Fail-fast config: behaviorally tested (rejects missing/default/weak secrets in 4/4 cases); prod booted with real Gitea-injected secrets

Incidents & discoveries during rollout:

  • Deploy task 80 failed on a latent CI bug unrelated to Phase 0: unpinned corepack resolved pnpm 11, which hard-errors on unreviewed dependency build scripts (ERR_PNPM_IGNORED_BUILDS). Fixed in d874cf5 by pinning packageManager: pnpm@10.33.1 and completing the build-script review in pnpm-workspace.yaml (approve @swc/core, esbuild; ignore @scarf/scarf). A failed build never touches running containers — prod was unaffected.
  • The Gitea repo is a pull-mirror (no direct pushes). Deploys are triggered by pushing to GitHub and then running a mirror-sync via the Gitea API from the VPS (token via gitea admin user generate-access-token, POST /repos/admin/wealthysmart/mirror-sync from inside the container — port 3000 is not published on the host).
  • Dev credential change: dev no longer accepts admin/admin. The generated dev password lives in the gitignored .env (old file backed up as .env.bak-phase0). Prod credentials unchanged.
  • Two temporary phase0-sync-* Gitea tokens should be revoked in Gitea UI → Settings → Applications.

Corrections to the review docs found during implementation: none beyond those already noted in README.md.

Phase 1 — Foundations: Tests, Migrations, Time ✅ DONE

Completed 2026-06-09.

Plan item Status Commit
1.1 pytest harness, 55-test suite (no network, SQLite fixtures) ✅ c725c14
1.1 CI gate: test job (pytest + typecheck) blocks deploy ✅ (workflow)
1.2 Cycle-math characterization + month validation (BE-07) ✅ 0a4c3e9, c725c14
1.3 Alembic adoption: autogen baseline + stamp-or-upgrade startup ✅ 9a25c4b
1.4 Datetime sweep: 29 utcnow sites → app.timeutil.utcnow() ✅ 996bd43
1.5 Decimal-equivalence baseline (float behavior pinned by tests) ✅ c725c14
Pre-req: all 20 frontend type errors fixed, typecheck green ✅ 49b96ed

Key findings & decisions:

  • BE-06 is a FALSE POSITIVE. get_cycle_range(Y,M) returns the cycle starting M/18; budget month M composes get_previous_cycle → [(M-1)/18, M/18), exactly as the code comment and the frontend convention state. Empirically validated against prod: May 2026 budget's credit-card figure reproduced by independent SQL over the cycle window (95 transactions exactly, refunds to the colón, 0.13% residual from a single EUR transaction the simplified SQL can't convert). Convention now pinned by tests/test_cycle_math.py and the docstring.
  • Datetime strategy: all DB columns are naive TIMESTAMP, so the sweep deliberately keeps naive-UTC semantics via a shared app/timeutil.py::utcnow() (non-deprecated API, zero behavior change). Going tz-aware would have poisoned naive/aware comparisons. TIMESTAMPTZ migration deferred to Phase 2 — now a one-line change.
  • Alembic baseline (c3da001a0eb3) autogenerated against empty Postgres, then schema-diffed against the live schema until column-identical. Two model fixes fell out: deferred_to_next_cycle now declares its server_default (live DBs have it from the legacy ALTER), usersettings.data is JSONB on Postgres (matching live) via a dialect variant. Startup stamps pre-Alembic DBs, upgrades fresh ones, under a pg advisory lock (prod uvicorn runs 2 workers → lifespan runs twice).
  • Verified locally: adoption + idempotent re-run on dev DB, fresh 13-table build on empty DB, full dev-container boot through the Alembic path, 55/55 tests, typecheck 0 errors, production vite build.

Dev environment note: backend dev tooling lives in backend/.venv (gitignored); pytest and alembic run from there. See CLAUDE.md for the migration workflow.

Phase 2 — Backend Correctness & Robustness ⏳ NOT STARTED

Phase 3 — Frontend Data Layer & Feedback ⏳ NOT STARTED

Phase 4 — UX, Trust & Features ⏳ NOT STARTED

Reference in New Issue View Git Blame Copy Permalink